netdev - Re: [PATCH net-next v4 0/9] Introduce support to lazy initialize mostly static keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131020033313.GB27787@order.stressinduktion.org>
Date:	Sun, 20 Oct 2013 05:33:13 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 0/9] Introduce support to lazy initialize mostly static keys

On Sat, Oct 19, 2013 at 07:46:35PM -0400, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date: Sat, 19 Oct 2013 21:48:50 +0200
> 
> > This series implements support for delaying the initialization of secret
> > keys, e.g. used for hashing, for as long as possible. This functionality
> > is implemented by a new macro, net_get_random_bytes.
> > 
> > I already used it to protect the socket hashes, the syncookie secret
> > (most important) and the tcp_fastopen secrets.
> > 
> > Changelog:
> > v2) Use static_keys in net_get_random_once to have as minimal impact to
> >     the fast-path as possible.
> > v3) added patch "static_key: WARN on usage before jump_label_init was called":
> >     Patch "x86/jump_label: expect default_nop if static_key gets enabled
> >     on boot-up" relaxes the checks for using static_key primitives before
> >     jump_label_init. So tighten them first.
> > v4) Update changelog on the patch "static_key: WARN on usage before
> >     jump_label_init was called"
> 
> Although I was very skeptical about these changes when you first posted
> them, I am quite happy with this series now.

Thank you, too! I was afraid that without the necessary acks from x86
and jump-label maintainers it would have been impossible to merge.

> 
> Thanks for working on this and not giving up :-)
> 
> Series applied, thanks a lot!

I received build warnings from kbuild just after merging and will fix
them up. Mostly ia64 and allnoconfig. Will send patches soon.

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html