netdev - Re: [net-next PATCH] macvlan: resolve ENOENT errors on creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131021213441.GB18170@redhat.com>
Date:	Mon, 21 Oct 2013 23:34:41 +0200
From:	Veaceslav Falico <vfalico@...hat.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	nhorman@...driver.com, netdev@...r.kernel.org
Subject: Re: [net-next PATCH] macvlan: resolve ENOENT errors on creation

On Mon, Oct 21, 2013 at 02:28:02PM -0700, John Fastabend wrote:
>After the commit below attempting to create macvlan devices was
>resulting in ENOENT errors,
>
># ip link add link p3p2 type macvlan
>RTNETLINK answers: Invalid argument
>
>This happens because netdev_upper_dev_link() is called before
>register_netdevice() in the macvlan code. Through a call chain
>this results in a call to __netdev_adjacent_dev_insert() and
>finally a sysfs_create_link(). This requires the kobject of
>the macvlan to be registered which is done in register_netdevice().
>If there is no kobject which is the case here the ENOENT error
>is seen on the command line.
>
>To resolve this move the netdev_upper_dev_link() call below
>the register_netdevice() call. This aligns with vlan driver
>flow.

Yep, changed the vlan code, but didn't see the macvlan. My cscope didn't
catch it for some reason :-/.

I've also checked - there are no users except bonding, vlan (both are ok),
and macvlan.

Acked-by: Veaceslav Falico <vfalico@...hat.com>

>
>Regression introduced here,
>
>commit 5831d66e8097aedfa3bc35941cf265ada2352317
>Author: Veaceslav Falico <vfalico@...hat.com>
>Date:   Wed Sep 25 09:20:32 2013 +0200
>
>    net: create sysfs symlinks for neighbour devices
>
>CC: Veaceslav Falico <vfalico@...hat.com>
>CC: Neil Horman <nhorman@...driver.com>
>Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
>---
> drivers/net/macvlan.c |   11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
>index 9bf46bd..cc9845e 100644
>--- a/drivers/net/macvlan.c
>+++ b/drivers/net/macvlan.c
>@@ -828,22 +828,21 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev,
> 		eth_hw_addr_inherit(dev, lowerdev);
> 	}
>
>+	port->count += 1;
>+	err = register_netdevice(dev);
>+	if (err < 0)
>+		goto destroy_port;
>+
> 	err = netdev_upper_dev_link(lowerdev, dev);
> 	if (err)
> 		goto destroy_port;
>
>-	port->count += 1;
>-	err = register_netdevice(dev);
>-	if (err < 0)
>-		goto upper_dev_unlink;
>
> 	list_add_tail_rcu(&vlan->list, &port->vlans);
> 	netif_stacked_transfer_operstate(lowerdev, dev);
>
> 	return 0;
>
>-upper_dev_unlink:
>-	netdev_upper_dev_unlink(lowerdev, dev);
> destroy_port:
> 	port->count -= 1;
> 	if (!port->count)
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html