netdev - Re: [PATCH net] tcp: initialize passive-side sk_pacing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131021.185847.1300529113406521142.davem@davemloft.net>
Date:	Mon, 21 Oct 2013 18:58:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ncardwell@...gle.com, netdev@...r.kernel.org, edumazet@...gle.com,
	ycheng@...gle.com
Subject: Re: [PATCH net] tcp: initialize passive-side sk_pacing_rate after
 3WHS

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 21 Oct 2013 13:36:34 -0700

> On Mon, 2013-10-21 at 15:40 -0400, Neal Cardwell wrote:
>> For passive TCP connections, upon receiving the ACK that completes the
>> 3WHS, make sure we set our pacing rate after we get our first RTT
>> sample.
> 
>> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Cc: Yuchung Cheng <ycheng@...gle.com>
>> ---
>>  net/ipv4/tcp_input.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
>> index 53974c7..a16b01b 100644
>> --- a/net/ipv4/tcp_input.c
>> +++ b/net/ipv4/tcp_input.c
>> @@ -5712,6 +5712,8 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb,
>>  		} else
>>  			tcp_init_metrics(sk);
>>  
>> +		tcp_update_pacing_rate(sk);
>> +
>>  		/* Prevent spurious tcp_cwnd_restart() on first data packet */
>>  		tp->lsndtime = tcp_time_stamp;
>>  
> 
> Seems good to me, thanks !
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html