netdev - Re: [PATCH net-next v3 02/07] r8169: Support for byte queue limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1382349331.25689.15.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 21 Oct 2013 10:55:31 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Tino Reichardt <milky-kernel@...ilk.de>
CC:	<netdev@...r.kernel.org>,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Igor Maravic <igorm@....rs>,
	Francois Romieu <romieu@...zoreil.com>
Subject: Re: [PATCH net-next v3 02/07] r8169: Support for byte queue limits

On Sun, 2013-10-20 at 21:23 +0200, Tino Reichardt wrote:
> Changes to r8169 driver to use byte queue limits.
[...]
> +		if (unlikely(bql_disable))
> +			netdev_completed_queue(dev, pkts_compl, bytes_compl);
>  		if (netif_queue_stopped(dev) &&
>  		    TX_FRAGS_READY_FOR(tp, MAX_SKB_FRAGS)) {
>  			netif_wake_queue(dev);

This is obviously wrong.  Please limit your changes to drivers you can
actually test.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html