netdev - Re: [PATCH 15/15] net: enic: remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9C4CB4066E545D4D9D728B3238E19CA5014B62CE@xmb-aln-x07.cisco.com>
Date:	Mon, 21 Oct 2013 14:02:38 +0000
From:	"Sujith Sankar (ssujith)" <ssujith@...co.com>
To:	Jingoo Han <jg1.han@...sung.com>,
	"'David S. Miller'" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Christian Benvenuti (benve)" <benve@...co.com>,
	"'Govindarajulu Varadarajan'" <govindarajulu90@...il.com>,
	"Neel Patel (neepatel)" <neepatel@...co.com>
Subject: Re: [PATCH 15/15] net: enic: remove unnecessary pci_set_drvdata()

This looks good to me.

Regards,
-Sujith

On 18/10/13 5:55 AM, "Jingoo Han" <jg1.han@...sung.com> wrote:

>The driver core clears the driver data to NULL after device_release
>or on probe failure. Thus, it is not needed to manually clear the
>device driver data to NULL.
>
>Signed-off-by: Jingoo Han <jg1.han@...sung.com>
>---
> drivers/net/ethernet/cisco/enic/enic_main.c |    2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c
>b/drivers/net/ethernet/cisco/enic/enic_main.c
>index 7b756cf9..ff78dfa 100644
>--- a/drivers/net/ethernet/cisco/enic/enic_main.c
>+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
>@@ -2309,7 +2309,6 @@ err_out_release_regions:
> err_out_disable_device:
> 	pci_disable_device(pdev);
> err_out_free_netdev:
>-	pci_set_drvdata(pdev, NULL);
> 	free_netdev(netdev);
> 
> 	return err;
>@@ -2338,7 +2337,6 @@ static void enic_remove(struct pci_dev *pdev)
> 		enic_iounmap(enic);
> 		pci_release_regions(pdev);
> 		pci_disable_device(pdev);
>-		pci_set_drvdata(pdev, NULL);
> 		free_netdev(netdev);
> 	}
> }
>-- 
>1.7.10.4
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html