netdev - Re: [PATCH 2/3] net: tulip: use DEFINE_PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP6odjg8cpyf-sntLPoVBsNX_J4n2cmPSaOA=e_daTFqrC5VbQ@mail.gmail.com>
Date:	Mon, 21 Oct 2013 20:37:40 -0700
From:	Grant Grundler <grantgrundler@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"open list:TULIP NETWORK DRI..." <netdev@...r.kernel.org>,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH 2/3] net: tulip: use DEFINE_PCI_DEVICE_TABLE

On Mon, Oct 21, 2013 at 8:00 PM, Jingoo Han <jg1.han@...sung.com> wrote:
> This macro is used to create a struct pci_device_id array.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

LGTM.

Acked-by: Grant Grundler <grundler@...isc-linux.org>

> ---
>  drivers/net/ethernet/dec/tulip/de4x5.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
> index 263b92c..c05b66d 100644
> --- a/drivers/net/ethernet/dec/tulip/de4x5.c
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c
> @@ -2328,7 +2328,7 @@ static void de4x5_pci_remove(struct pci_dev *pdev)
>         pci_disable_device (pdev);
>  }
>
> -static struct pci_device_id de4x5_pci_tbl[] = {
> +static DEFINE_PCI_DEVICE_TABLE(de4x5_pci_tbl) = {
>          { PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_TULIP,
>            PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
>          { PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_TULIP_PLUS,
> --
> 1.7.10.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html