lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Oct 2013 17:43:49 +0200 From: Nicolas Dichtel <nicolas.dichtel@...nd.com> To: Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [PATCH stable 3.11] sit: amend "allow to use rtnl ops on fb tunnel" Le 22/10/2013 16:59, Willem de Bruijn a écrit : > Amend backport to 3.11.y of > > [ Upstream commit 205983c43700ac3a81e7625273a3fa83cd2759b5 ] > > The discussion thread in the upstream commit mentions that in > backports to stable-* branches, the line > > - unregister_netdevice_queue(sitn->fb_tunnel_dev, &list); > > must be omitted if that branch does not have commit 5e6700b3bf98 > ("sit: add support of x-netns"). This line has correctly been omitted > in the backport to 3.10, which indeed does not have that commit. > > It was also removed in the backport to 3.11.y, which does have that > commit. > > This causes the following steps to hit a BUG at net/core/dev.c:5039: > > `modprobe sit; rmmod sit` > > The bug demonstrates that it causes a device to be unregistered twice. > The simple fix is to apply the one line in the upstream commit that > was dropped in the backport to 3.11 (3783100374653e2e7fbdf68c710f5). > This brings the logic in line with upstream linux, net and net-next > branches. > > Signed-off-by: Willem de Bruijn <willemb@...gle.com> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists