netdev - Re: [PATCH net-next] net: add missing dev_put() in __netdev_adjacent_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131023133652.GF25073@redhat.com>
Date:	Wed, 23 Oct 2013 15:36:52 +0200
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] net: add missing dev_put() in
 __netdev_adjacent_dev_insert

On Wed, Oct 23, 2013 at 03:28:56PM +0200, Nikolay Aleksandrov wrote:
>I think that a dev_put() is needed in the error path to preserve the
>proper dev refcount.

True, forgot about it. Thanks for spotting this!

Acked-by: Veaceslav Falico <vfalico@...hat.com>

>
>CC: Veaceslav Falico <vfalico@...hat.com>
>Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 0918aad..bdffd65 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -4648,6 +4648,7 @@ remove_symlinks:
>
> free_adj:
> 	kfree(adj);
>+	dev_put(adj_dev);
>
> 	return ret;
> }
>-- 
>1.8.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html