netdev - Re: [PATCH net] netconsole: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131024205934.GA26855@electric-eye.fr.zoreil.com>
Date:	Thu, 24 Oct 2013 22:59:34 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	David Miller <davem@...emloft.net>, David.Laight@...LAB.COM,
	vfalico@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] netconsole: fix NULL pointer dereference

Nikolay Aleksandrov <nikolay@...hat.com> :
> On 10/24/2013 07:56 PM, David Miller wrote:
> > From: "David Laight" <David.Laight@...LAB.COM>
[...]
> >> Ditto - might be worth saying:
> >>     /* Acquire lock to wait for any write_msg() to complete. */
> > 
> > Something this subtle definitely requires a comment.
> > 
> Okay, thank you all for the reviews. I will re-submit a v2 with
> the comment edited.

"edited" as in "removed" because:
1. an irq disabling spinlock loudly states what the intent is ("hey, this
   netconsole stuff could be concurrently used in irq or softirq context").
2. the target_list_lock spinlock itself tells where to look for:

drivers/net/netconsole.c
[...]
/* This needs to be a spinlock because write_msg() cannot sleep */
static DEFINE_SPINLOCK(target_list_lock);

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html