netdev - Re: [PATCH net-next] jazzsonic: printk() style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5269962A.5050306@cogentembedded.com>
Date:	Fri, 25 Oct 2013 01:50:34 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Tom D'Alba <tomster595@...il.com>, netdev@...r.kernel.org
CC:	Tom D'Alba <dalbat@....edu>
Subject: Re: [PATCH net-next] jazzsonic: printk() style fixes

Hello.

On 10/25/2013 01:39 AM, Tom D'Alba wrote:

> From: Tom D'Alba <dalbat@....edu>

> Fixed printk() format by adding correct KERN_ statuses.

> Reviewed-by: Nicholas Guthrie <nickg4317@...il.com>
> Reviewed-by: Sarah Williams <swilliams704@...il.com>
> Reviewed-by: Jason Lee <calccrypto@...il.com>
> Signed-off-by: Tom D'Alba <dalbat@....edu>
> ---
>   drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
> index 79257f7..3a04d32 100644
> --- a/drivers/net/ethernet/natsemi/jazzsonic.c
> +++ b/drivers/net/ethernet/natsemi/jazzsonic.c
> @@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
>   	 */
>   	silicon_revision = SONIC_READ(SONIC_SR);
>   	if (sonic_debug > 1)
> -		printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
> +	  printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);

    Please don't change the indentation.

> @@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
>   		i++;
>
>   	if (known_revisions[i] == 0xffff) {
> -		printk("SONIC ethernet controller not found (0x%4x)\n",
> +		printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
>   		       silicon_revision);
>   		goto out;
>   	}
>
>   	if (sonic_debug  &&  version_printed++ == 0)
> -		printk(version);
> +	      printk(KERN_INFO version);

    Same here.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html