netdev - Re: [PATCH net-next] macsonic: Updated printk() statement to KERN style leading argument.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1382653852.22433.82.camel@joe-AO722>
Date:	Thu, 24 Oct 2013 15:30:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	Matt Zanchelli <zanchm@....edu>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] macsonic: Updated printk() statement to KERN
 style leading argument.

On Thu, 2013-10-24 at 21:37 +0000, Matt Zanchelli wrote:
> Updated prinkt() statement in mac_sonic_probe() function to match current
> convention of using KERN style leading argument.

s/prinkt/printk/

> diff --git a/drivers/net/ethernet/natsemi/macsonic.c b/drivers/net/ethernet/natsemi/macsonic.c
[]
> @@ -601,7 +601,7 @@ found:
>  	if (err)
>  		goto out;
>  
> -	printk("%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);
> +	printk(KERN_INFO "%s: MAC %pM IRQ %d\n", dev->name, dev->dev_addr, dev->irq);

It'd be nicer to use:

	netdev_info(dev, "MAC %pM IRQ %d\n", dev->dev_addr, dev->irq);

Nicer still to convert all the printks in this
file to netdev_<level> where possible.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html