netdev - Re: [PATCH next] be2net: add support for ndo_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1382595238.7572.38.camel@edumazet-glaptop.roam.corp.google.com>
Date:	Wed, 23 Oct 2013 23:13:58 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sathya Perla <sathya.perla@...lex.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH next] be2net: add support for ndo_busy_poll

On Thu, 2013-10-24 at 11:17 +0530, Sathya Perla wrote:
> Includes:
> - ndo_busy_poll implementation
> - Locking between napi and busy_poll
> - Fix rx_post_starvation (replenish rx-queues in out-of-mememory scenario)
>   logic to accomodate busy_poll.

>  	if (work_done) {
> +		gfp_t gfp = (polling == BUSY_POLLING) ? GFP_KERNEL : GFP_ATOMIC;
> +
>  		be_cq_notify(adapter, rx_cq->id, true, work_done);
>  

I do not think its right.

ndo_busy_poll() is not allowed to sleep.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html