netdev - RE: [PATCH net] netconsole: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Oct 2013 11:39:02 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Veaceslav Falico" <vfalico@...hat.com>,
	"Nikolay Aleksandrov" <nikolay@...hat.com>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: RE: [PATCH net] netconsole: fix NULL pointer dereference

> >Taking the spinlock seems like the cleanest way to insure there's noone
> >running in parallel, but I'm open to suggestions as I'm not satisfied with
> >the looks of this. I'll prepare a net-next patchset for netconsole soon to
> >clean it up properly, all of these can be easily simplified.
> 
> First when I've seen 'spin_lock(); a = 1; spin_unlock()' I've thought
> "WTF?", however indeed it will stop us racing with write_msg().

Ditto - might be worth saying:
    /* Acquire lock to wait for any write_msg() to complete. */

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html