netdev - Re: [PATCH net] net: sched: Don't free f before it is allocated in route4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131024154157.GA4837@cpaasch-mac>
Date:	Thu, 24 Oct 2013 17:41:57 +0200
From:	Christoph Paasch <christoph.paasch@...ouvain.be>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Jing Wang <windsdaemon@...il.com>
Subject: Re: [PATCH net] net: sched: Don't free f before it is allocated in
 route4_change

On 24/10/13 - 08:05:57, Eric Dumazet wrote:
> On Thu, 2013-10-24 at 16:59 +0200, Christoph Paasch wrote:
> > On 24/10/13 - 07:54:33, Eric Dumazet wrote:
> 
> > > I see no bug here, you missed the "goto reinsert;"
> > 
> > Ups - sorry...
> > 
> 
> Yeah, trying to find bugs in Alexey code is really tricky ;)

Yeah :)

Instead of the goto, a simple if {} else {} would have made it
more readable IMO.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html