netdev - Re: [PATCH net-next 1/6] epic100: replace printk with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Oct 2013 23:41:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ben Boeckel <mathstuf@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/6] epic100: replace printk with netdev_ calls

On Fri, 2013-10-25 at 02:26 -0400, Ben Boeckel wrote:
> Signed-off-by: Ben Boeckel <mathstuf@...il.com>

Hi Ben.

Please run your patches through checkpatch.pl

> diff --git a/drivers/net/ethernet/smsc/epic100.c b/drivers/net/ethernet/smsc/epic100.c
[]
> @@ -490,7 +488,7 @@ static int epic_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (ret < 0)
>  		goto err_out_unmap_rx;
>  
> -	printk(KERN_INFO "%s: %s at %lx, IRQ %d, %pM\n",
> +	netdev_info(dev, "%s: %s at %lx, IRQ %d, %pM\n",
>  	       dev->name, pci_id_tbl[chip_idx].name,
>  	       (long)pci_resource_start(pdev, EPIC_BAR), pdev->irq,
>  	       dev->dev_addr);

Please align the subsequent lines to the open parenthesis
and this conversion would now emit dev->name twice.

Try:
	netdev_info(dev, "%s at %lx, IRQ %d, %pM\n",
		    pci_id_tbl[chip_idx].name,
		    (long)pci_resource_start(pdev, EPIC_BAR),
		    pdev->irq, dev->dev_addr);

> @@ -703,7 +701,7 @@ static int epic_open(struct net_device *dev)
>  			mdio_write(dev, ep->phys[0], MII_BMCR, media2miictl[dev->if_port&15]);
>  		if (dev->if_port == 1) {
>  			if (debug > 1)
> -				printk(KERN_INFO "%s: Using the 10base2 transceiver, MII "
> +				netdev_info(dev, "%s: Using the 10base2 transceiver, MII "
>  					   "status %4.4x.\n",

Please coalesce the format fragments into a single line.

>  					   dev->name, mdio_read(dev, ep->phys[0], MII_BMSR));

same problem with duplicate dev->name

etc.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html