netdev - Re: [gpio:for-next 67/67] pch_gbe_main.c:undefined reference to `devm_gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYvOMiBOXRi61LjemMSoafR6kv3XoY=A5E90hwMumdw9A@mail.gmail.com>
Date:	Fri, 25 Oct 2013 12:41:57 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Darren Hart <dvhart@...ux.intel.com>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:	Fengguang Wu <fengguang.wu@...el.com>,
	David Cohen <david.a.cohen@...ux.intel.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [gpio:for-next 67/67] pch_gbe_main.c:undefined reference to `devm_gpio_request_one'

On Fri, Oct 25, 2013 at 12:24 PM, Darren Hart <dvhart@...ux.intel.com> wrote:
> On Fri, 2013-10-25 at 11:34 +0200, Linus Walleij wrote:

> Minnow doesn't currently have a CONFIG_ upstream which can be used to
> force this selection.

Well it wouldn't help with randconfig or allyesconfig anyway.

>> Is there some default y we can add so this gets compiled for this
>> entire board, or shall I set:
>>
>> depends on PCH_GBE
>> default y
>>
>> On the GPIO_LYNXPOINT or GPIO_PCH driver?
>
> Why would GPIO_PCH depend on PCH_GBE? The inverse is certainly true for
> MinnowBoard.

OK this was the wrong idea.

> I had some MinnowBoard Kconfig bits in my early drivers, but they
> included things like CONFIG_MINNOWBOARD which is not upstream (rightly
> so) but it means I don't have a way to conditionally make PCH_GBE
> dependent on GPIO_PCH and GPIOLIB.
>
> I wouldn't object to adding a dependency to GPIO_PCH and GPIOLIB
> unconditionally for PCH_GBE as GPIO_PCH is the same chip... but I don't
> know if David Miller would be amenable to that.

Well we should probably just stick a dependency to GPIOLIB in there.

- It #includes <linux/gpio.h>
- It uses gpiolib functions to do something vital

It was just happy that dummy versions were slotted in until now.

I'll post the following:
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/etherne
index a588ffde9700..f2528262aba7 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -4,7 +4,7 @@

 config PCH_GBE
        tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
-       depends on PCI && (X86 || COMPILE_TEST)
+       depends on PCI && GPIOLIB && (X86 || COMPILE_TEST)
        select MII
        select PTP_1588_CLOCK_PCH
        ---help---

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html