netdev - Re: [PATCH net 1/2] qlcnic: Do not force adapter to perform LRO without destination IP check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1382761028.4032.36.camel@edumazet-glaptop.roam.corp.google.com>
Date:	Fri, 25 Oct 2013 21:17:08 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Shahed Shaikh <shahed.shaikh@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH net 1/2] qlcnic: Do not force adapter to perform LRO
 without destination IP check

On Fri, 2013-10-25 at 10:38 -0400, Shahed Shaikh wrote:
> From: Shahed Shaikh <shahed.shaikh@...gic.com>
> 
> Forcing adapter to perform LRO without destination IP check
> degrades the performance.


Hmm... the performance, or does it allow two packets belonging to
different flows being wrongly aggregated ?

It looks a critical bug fix, not only a performance issue.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html