netdev - Re: [PATCH RFC v2 3/4] net: mvmdio: slight optimisation of orion_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131026.014545.318441640809669571.davem@davemloft.net>
Date:	Sat, 26 Oct 2013 01:45:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	leigh@...inno.co.uk
Cc:	linux-arm-kernel@...ts.infradead.org,
	thomas.petazzoni@...e-electrons.com, netdev@...r.kernel.org,
	sebastian.hesselbarth@...il.com
Subject: Re: [PATCH RFC v2 3/4] net: mvmdio: slight optimisation of
 orion_mdio_write

From: Leigh Brown <leigh@...inno.co.uk>
Date: Thu, 24 Oct 2013 19:09:33 +0100

> Make only a single call to mutex_unlock in orion_mdio_write.
> 
> Signed-off-by: Leigh Brown <leigh@...inno.co.uk>

You patch does more than what you're talking about here in your
commit message.  In particular you're also changing the interpretation
of the orion_mdio_wait_ready() return value by changing the test
from < 0 to != 0.

Even if that is a legitimate change:

1) You're not describing it in the commit message at all.

2) It's a logically separate change, so should go into a completely
   separate patch.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html