netdev - Re: [PATCH net-next 3/5] 6lowpan: use netdev_alloc_skb instead dev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131026.173226.702320284607764282.davem@davemloft.net>
Date:	Sat, 26 Oct 2013 17:32:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	alex.aring@...il.com, alex.bluesman.smirnov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, werner@...esberger.net,
	dbaryshkov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/5] 6lowpan: use netdev_alloc_skb instead
 dev_alloc_skb

From: Joe Perches <joe@...ches.com>
Date: Fri, 25 Oct 2013 23:01:44 -0700

> On Sat, 2013-10-26 at 01:42 -0400, David Miller wrote:
>> From: Alexander Aring <alex.aring@...il.com>
>> Date: Thu, 24 Oct 2013 22:51:42 +0200
>> 
>> > @@ -1127,12 +1127,12 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head,
>> >  
>> >  	lowpan_raw_dump_inline(__func__, "6lowpan fragment header", head, hlen);
>> >  
>> > -	frag = dev_alloc_skb(hlen + mlen + plen + IEEE802154_MFR_SIZE);
>> > +	frag = netdev_alloc_skb(skb->dev, hlen + mlen +
>> > +			plen + IEEE802154_MFR_SIZE);
>> 
>> Please indent this properly.
>> 
>> It should be something like:
>> 
>> 	frag = netdev_alloc_skb(skb->dev, hlen + mlen +
>> 					  plen + IEEE802154_MFR_SIZE);
> 
> Maybe better as:
> 
> 	frag = netdev_alloc_skb(skb->dev,
> 				hlen + mlen + plen + IEEE802154_MFR_SIZE);

Either is fine with me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html