lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 Oct 2013 10:55:39 +0800 From: wangweidong <wangweidong1@...wei.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, <davem@...emloft.net>, <nhorman@...driver.com>, <vyasevich@...il.com> CC: <dingtianhong@...wei.com>, <linux-sctp@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH 1/4] sctp: merge two if statements to one On 2013/10/25 21:04, Sergei Shtylyov wrote: > Hello. > > On 25-10-2013 5:50, Wang Weidong wrote: > >> Two if statements do the same work, maybe we can merge them to >> one. There is just code simplification, no functional changes. > >> Signed-off-by: Wang Weidong <wangweidong1@...wei.com> >> --- >> net/sctp/auth.c | 12 ++++-------- >> 1 file changed, 4 insertions(+), 8 deletions(-) > > I understand what I noticed below is not your typos but maybe it's time to fix them? Yeah, I will fix them. Thanks. > >> diff --git a/net/sctp/auth.c b/net/sctp/auth.c >> index 8c4fa5d..19fb0ae 100644 >> --- a/net/sctp/auth.c >> +++ b/net/sctp/auth.c >> @@ -539,18 +539,14 @@ struct sctp_hmac *sctp_auth_asoc_get_hmac(const struct sctp_association *asoc) >> for (i = 0; i < n_elt; i++) { >> id = ntohs(hmacs->hmac_ids[i]); >> >> - /* Check the id is in the supported range */ >> - if (id > SCTP_AUTH_HMAC_ID_MAX) { >> - id = 0; >> - continue; >> - } >> - >> - /* See is we support the id. Supported IDs have name and >> + /* Check the id is in the supported range. And >> + * see is we support the id. Supported IDs have name and > > s/is/if/. > >> * length fields set, so that we can allocated and use > > s/allocated/allocate/. > > WBR, Sergei > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists