netdev - [PATCH 0/2] net_sched: Remove broken tc actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fvrmu909.fsf@xmission.com>
Date:	Sun, 27 Oct 2013 06:40:54 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	David Miller <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, alexander.h.duyck@...el.com,
	jhs@...atatu.com
Subject: [PATCH 0/2] net_sched: Remove broken tc actions

While auditing the code to make certain it would be safe to enable the
user namespace root to use tc actions I stumbled on the strange fact
that two of the tc modules in the kernel have been broken for more
years than I care to think about.

In particular neither of these two modules implements the tc_action_ops
lookup method.  Which means that in practice neither RTM_GETACTION nor
RTM_DELACTION work.  And with RTM_DELACTION broken that looks like a
permanent leak of kernel memory to me.

A leak I am not happy at root having and certainly not something I want
to allow unprivileged users access to.

On the premise that 5+ years is too long to wait for someone to notice,
complain and get this code fixed let's just remove these broken tc
modules.

Eric W. Biederman (2):
      net_sched: Remove broken act_skbedit
      net_sched: Remove broken act_simple

 include/net/tc_act/tc_defact.h         |   14 --
 include/net/tc_act/tc_skbedit.h        |   36 -----
 include/uapi/linux/tc_act/Kbuild       |    2 -
 include/uapi/linux/tc_act/tc_defact.h  |   19 ---
 include/uapi/linux/tc_act/tc_skbedit.h |   46 -------
 net/sched/Kconfig                      |   25 ----
 net/sched/Makefile                     |    2 -
 net/sched/act_simple.c                 |  225 --------------------------------
 net/sched/act_skbedit.c                |  224 -------------------------------
 9 files changed, 0 insertions(+), 593 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html