netdev - Re: [PATCH net-next v2 0/5] bonding: patchset for rcu use in bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131027.163712.1324471504006808112.davem@davemloft.net>
Date:	Sun, 27 Oct 2013 16:37:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, andy@...yhouse.net, nikolay@...hat.com,
	vfalico@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/5] bonding: patchset for rcu use in
 bonding

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Thu, 24 Oct 2013 11:08:35 +0800

> The slave list will add and del by bond_master_upper_dev_link() and bond_upper_dev_unlink(),
> which will call call_netdevice_notifiers(), even it is safe to call it in write bond lock now,
> but we can't sure that whether it is safe later, because other drivers may deal NETDEV_CHANGEUPPER
> in sleep way, so I didn't admit move the bond_upper_dev_unlink() in write bond lock.
> 
> now the bond_for_each_slave only protect by rtnl_lock(), maybe use bond_for_each_slave_rcu is a good
> way to protect slave list for bond, but as a system slow path, it is no need to transform bond_for_each_slave()
> to bond_for_each_slave_rcu() in slow path, so in the patchset, I will remove the unused read bond lock
> for monitor function, maybe it is a better way, I will wait to accept any relay for it.
> 
> Thanks for the Veaceslav Falico opinion.
> 
> v2: add and modify commit for patchset and patch, it will be the first step for the whole patchset.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html