netdev - Re: [PATCH 0/2] net_sched: Remove broken tc actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <526EEBD9.8040006@mojatatu.com>
Date:	Mon, 28 Oct 2013 18:57:29 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Alexander Duyck <alexander.duyck@...il.com>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	alexander.h.duyck@...el.com
Subject: Re: [PATCH 0/2] net_sched: Remove broken tc actions

On 10/27/13 16:37, Alexander Duyck wrote:

> The primary use case for act_skbedit was to have it associated with a
> filter.  I based it off of act_simple so it isn't surprising that it
> inherited this issue.

Thats almost 100% of the use cases.

>
>  From what I can tell all of the other actions are just using
> tcf_hash_search for lookup.  Is there anything special that is needed in
> order to add the lookup call, or could we just add a one liner
> associating simple and skbedit lookup with tcf_hash_search?
>

Yes, that would do it. But dont bother - let me just send a generic
patch that will assume that for any other action that doesnt do it.
Will do it likely tomorow.


cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html