lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Oct 2013 12:01:35 +0000 From: Wei Liu <wei.liu2@...rix.com> To: Jan Beulich <JBeulich@...e.com> CC: Wei Liu <wei.liu2@...rix.com>, <david.vrabel@...rix.com>, Ian Campbell <ian.campbell@...rix.com>, xen-devel <xen-devel@...ts.xenproject.org>, <annie.li@...cle.com>, Jason Luan <jianhai.luan@...cle.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH net V2] xen-netback: use jiffies_64 value to calculate credit timeout On Mon, Oct 28, 2013 at 11:49:55AM +0000, Jan Beulich wrote: > >>> On 28.10.13 at 12:35, Wei Liu <wei.liu2@...rix.com> wrote: > > Two formal things: > > > --- a/drivers/net/xen-netback/netback.c > > +++ b/drivers/net/xen-netback/netback.c > > @@ -1185,18 +1185,17 @@ out: > > > > static bool tx_credit_exceeded(struct xenvif *vif, unsigned size) > > { > > - unsigned long now = jiffies; > > - unsigned long next_credit = > > - vif->credit_timeout.expires + > > - msecs_to_jiffies(vif->credit_usec / 1000); > > + u64 now = get_jiffies_64(); > > + u64 next_credit = vif->credit_window_start + > > + (u64)msecs_to_jiffies(vif->credit_usec / 1000); > > The cast to u64 seems pointless here. > > > @@ -1207,7 +1206,8 @@ static bool tx_credit_exceeded(struct xenvif *vif, unsigned size) > > vif->credit_timeout.function = > > tx_credit_callback; > > mod_timer(&vif->credit_timeout, > > - next_credit); > > + (unsigned long)next_credit); > > And the cast here seems pointless too (gcc doesn't warn about > truncations). > Will fix these, thanks. Wei. > Jan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists