netdev - Re: [PATCH 1/2] octeon_mgmt: remove double validation of mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52702C68.5060603@gmail.com>
Date:	Tue, 29 Oct 2013 14:45:12 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Laurent Navet <laurent.navet@...il.com>,
	Luka Perkov <luka@...nwrt.org>
CC:	davem@...emloft.net, jiri@...nulli.us, david.daney@...ium.com,
	wfp5p@...ginia.edu, gregkh@...uxfoundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] octeon_mgmt: remove double validation of mac address

On 10/29/2013 02:27 PM, Laurent Navet wrote:
> Mac address validity is already checked in of_get_mac_address().
> No need to do it twice.
>
> Signed-off-by: Laurent Navet <laurent.navet@...il.com>

Luka already sent this exact patch, and I acked his.

No need to do it twice.

David Daney


> ---
>   drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
> index 622aa75..1b326cbc 100644
> --- a/drivers/net/ethernet/octeon/octeon_mgmt.c
> +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
> @@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
>
>   	mac = of_get_mac_address(pdev->dev.of_node);
>
> -	if (mac && is_valid_ether_addr(mac))
> +	if (mac)
>   		memcpy(netdev->dev_addr, mac, ETH_ALEN);
>   	else
>   		eth_hw_addr_random(netdev);
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html