netdev - Re: [PATCH] bgmac: don't update slot on skb alloc/dma mapping error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rzxt2QMtLfD84pw7EtYqg1Qva4ah83hVQOKpeKy72bd5w@mail.gmail.com>
Date:	Tue, 29 Oct 2013 07:52:58 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Nathan Hintz <nlhintz@...mail.com>
Cc:	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] bgmac: don't update slot on skb alloc/dma mapping error

2013/10/29 Nathan Hintz <nlhintz@...mail.com>:
> Don't update the slot in "bgmac_dma_rx_skb_for_slot" unless both the
> skb alloc and dma mapping are successful; and free the newly allocated
> skb if a dma mapping error occurs.  This will prevent an skb leak upon
> returning when an error occurs.

In case of bgmac_dma_rx_skb_for_slot failure we're giving up anyway
(and freeing everything), but with your patch code is simpler to
understand, so I'm OK with that.

Acked-by: Rafał Miłecki <zajec5@...il.com>

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html