netdev - Re: [PATCH net-next v2] tipc: remove two indentation levels in tipc_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131030.165443.2187198550218718303.davem@davemloft.net>
Date:	Wed, 30 Oct 2013 16:54:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	David.Laight@...lab.com, maloy@...jonn.com,
	Paul.Gortmaker@...driver.com, jon.maloy@...csson.com,
	erik.hugne@...csson.com, andreas.bofjall@...csson.com,
	tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] tipc: remove two indentation levels in
 tipc_recv_msg routine

From: Ying Xue <ying.xue@...driver.com>
Date: Wed, 30 Oct 2013 11:26:57 +0800

> The message dispatching part of tipc_recv_msg() is wrapped layers of
> while/if/if/switch, causing out-of-control indentation and does not
> look very good. We reduce two indentation levels by separating the
> message dispatching from the blocks that checks link state and
> sequence numbers, allowing longer function and arg names to be
> consistently indented without wrapping. Additionally we also rename
> "cont" label to "discard" and add one new label called "unlock_discard"
> to make code clearer. In all, these are cosmetic changes that do not
> alter the operation of TIPC in any way.
> 
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> Reviewed-by: Erik Hugne <erik.hugne@...csson.com>
> Cc: David Laight <david.laight@...lab.com>
> Cc: Andreas Bofjäll <andreas.bofjall@...csson.com>
> ---
> v2: Incorporated comments from David Laight and Andreas Bofjäll

This patch looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html