netdev - Re: [PATCH] bgmac: pass received packet to the netif instead of copying it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131030.165845.354006604111494289.davem@davemloft.net>
Date:	Wed, 30 Oct 2013 16:58:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	zajec5@...il.com
Cc:	netdev@...r.kernel.org, openwrt-devel@...ts.openwrt.org,
	nlhintz@...mail.com
Subject: Re: [PATCH] bgmac: pass received packet to the netif instead of
 copying it

From: Rafa┅ Mi┅ecki <zajec5@...il.com>
Date: Wed, 30 Oct 2013 08:00:00 +0100

> Copying whole packets with skb_copy_from_linear_data_offset is a pretty
> bad idea. CPU was spending time in __copy_user_common and network
> performance was lower. With the new solution iperf-measured speed
> increased from 116Mb/s to 134Mb/s.
> 
> Signed-off-by: Rafa┅ Mi┅ecki <zajec5@...il.com>
> ---
> Changes since [RFC TRY#2]:
> 1) Fixed arguments alignment
> 2) Dropped code fixing old slot in case of bgmac_dma_rx_skb_for_slot
> failure. Thanks to Nathan patch bgmac_dma_rx_skb_for_slot doesn't
> change anything in slot in case it failed somewhere.

Looks good, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html