netdev - RE: [PATCH net 1/2] qlcnic: Do not force adapter to perform LRO without destination IP check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A46EE8FC4@avmb2.qlogic.org>
Date:	Wed, 30 Oct 2013 06:46:02 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [PATCH net 1/2] qlcnic: Do not force adapter to perform LRO
 without destination IP check

> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Saturday, October 26, 2013 9:47 AM
> To: Shahed Shaikh
> Cc: David Miller; netdev; Dept-NX Linux NIC Driver
> Subject: Re: [PATCH net 1/2] qlcnic: Do not force adapter to perform LRO
> without destination IP check
> 
> On Fri, 2013-10-25 at 10:38 -0400, Shahed Shaikh wrote:
> > From: Shahed Shaikh <shahed.shaikh@...gic.com>
> >
> > Forcing adapter to perform LRO without destination IP check degrades
> > the performance.
> 
> 
> Hmm... the performance, or does it allow two packets belonging to different
> flows being wrongly aggregated ?
> 
> It looks a critical bug fix, not only a performance issue.

Hi Eric,

That's not the case. When  destination IP check is skipped, due to a firmware bug, some packets take a slower path leading to performance issues.
Once the firmware issue is resolved we will revert this change in the driver to skip the des tip check.

Thanks,
Shahed