netdev - Re: [PATCH net-next 1/2] net: introduce skb_coalesce_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5272405A.4050708@redhat.com>
Date:	Thu, 31 Oct 2013 19:34:50 +0800
From:	Jason Wang <jasowang@...hat.com>
To:	Kmindg G <kmindg@...il.com>
CC:	davem@...emloft.net, edumazet@...gle.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	mst@...hat.com, rusty@...tcorp.com.au, mwdalton@...gle.com,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 1/2] net: introduce skb_coalesce_rx_frag()

On 10/31/2013 07:05 PM, Kmindg G wrote:
> On Thu, Oct 31, 2013 at 6:28 PM, Jason Wang <jasowang@...hat.com> wrote:
>> > Sometimes we need to coalesce the rx frags to avoid frag list. One example is
>> > virtio-net driver which tries to use small frags for both MTU sized packet and
>> > GSO packet. So this patch introduce skb_coalesce_rx_frag() to do this.
>> >
>> > Cc: Rusty Russell <rusty@...tcorp.com.au>
>> > Cc: Michael S. Tsirkin <mst@...hat.com>
>> > Cc: Michael Dalton <mwdalton@...gle.com>
>> > Cc: Eric Dumazet <edumazet@...gle.com>
>> > Signed-off-by: Jason Wang <jasowang@...hat.com>
>> > ---
>> >  include/linux/skbuff.h |  3 +++
>> >  net/core/skbuff.c      | 13 +++++++++++++
>> >  2 files changed, 16 insertions(+)
>> >
>> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
>> > index 2c15497..e34652b 100644
>> > --- a/include/linux/skbuff.h
>> > +++ b/include/linux/skbuff.h
>> > @@ -1372,6 +1372,9 @@ static inline void skb_fill_page_desc(struct sk_buff *skb, int i,
>> >  void skb_add_rx_frag(struct sk_buff *skb, int i, struct page *page, int off,
>> >                      int size, unsigned int truesize);
>> >
>> > +void skb_coalesce_rx_frag(struct sk_buff *skb, int i, int off, int size,
>> > +                         unsigned int truesize);
>> > +
>> >  #define SKB_PAGE_ASSERT(skb)   BUG_ON(skb_shinfo(skb)->nr_frags)
>> >  #define SKB_FRAG_ASSERT(skb)   BUG_ON(skb_has_frag_list(skb))
>> >  #define SKB_LINEAR_ASSERT(skb)  BUG_ON(skb_is_nonlinear(skb))
>> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
>> > index 0ab32fa..fdef994 100644
>> > --- a/net/core/skbuff.c
>> > +++ b/net/core/skbuff.c
>> > @@ -476,6 +476,19 @@ void skb_add_rx_frag(struct sk_buff *skb, int i, struct page *page, int off,
>> >  }
>> >  EXPORT_SYMBOL(skb_add_rx_frag);
>> >
>> > +void skb_coalesce_rx_frag(struct sk_buff *skb, int i, int off, int size,
>> > +                         unsigned int truesize)
>> > +{
>> > +       skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
>> > +
>> > +       skb_frag_size_add(frag, size);
>> > +       skb->len += size;
>> > +       skb->data_len += size;
>> > +       skb->truesize += truesize;
>> > +       skb_frag_unref(skb, i);
>> > +}
> I didn't see  you use "off" in skb_coalesce_rx_frag.
>

Ture, it's useless. Will post V2.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html