netdev - Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Oct 2013 14:49:30 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Mauro Carvalho Chehab <m.chehab@...sung.com>
Cc:	Hans Verkuil <hverkuil@...all.nl>, alsa-devel@...a-project.org,
	linux-doc@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-fbdev@...r.kernel.org, linux-nvme@...ts.infradead.org,
	linux-ide@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-samsung-soc@...r.kernel.org, linux-scsi@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net, b43-dev@...ts.infradead.org,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-crypto@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace
	dma_set_mask()+dma_set_coherent_mask() with new helper

On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote:
> Hi Russell,
> 
> Em Mon, 30 Sep 2013 13:57:47 +0200
> Hans Verkuil <hverkuil@...all.nl> escreveu:
> 
> > On 09/19/2013 11:44 PM, Russell King wrote:
> > > Replace the following sequence:
> > > 
> > > 	dma_set_mask(dev, mask);
> > > 	dma_set_coherent_mask(dev, mask);
> > > 
> > > with a call to the new helper dma_set_mask_and_coherent().
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> > 
> > Acked-by: Hans Verkuil <hans.verkuil@...co.com>
> 
> Somehow, I lost your original post (I got unsubscribed on a few days 
> from all vger mailing lists at the end of september).
> 
> I suspect that you want to sent this via your tree, right?

Yes please.

> If so:
> 
> Acked-by: Mauro Carvalho Chehab <m.chehab@...sung.com>

Added, thanks.

> > > -	err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> > > -	if (err)
> > > -		return -ENODEV;
> > > -	err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> > > +	err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > >  	if (err)
> > >  		return -ENODEV;

One thing I've just noticed is that return should be "return err" not
"return -ENODEV" - are you okay for me to change that in this patch?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html