netdev - Re: [PATCH net-next 2/6] qlcnic: Replace kzalloc() with vzalloc().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131102.011459.236177037024354702.davem@davemloft.net>
Date:	Sat, 02 Nov 2013 01:14:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	himanshu.madhani@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com,
	manish.chopra@...gic.com
Subject: Re: [PATCH net-next 2/6] qlcnic: Replace kzalloc() with vzalloc().

From: Himanshu Madhani <himanshu.madhani@...gic.com>
Date: Fri, 1 Nov 2013 16:51:25 -0400

> From: Manish Chopra <manish.chopra@...gic.com>
> 
> o Some of the places kzalloc() is not required. Replace it
>   with vzalloc() wherever it is not used appropriately
> 
> Signed-off-by: Manish Chopra <manish.chopra@...gic.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@...gic.com>

This commit message is terrible.

In what way is kzalloc() inappropriate for these allocations?

Many of them are quite small, and vzalloc() is completely inappropriate
to use in such cases.

You should only use vzalloc() for HUGE allocations, those which
kzalloc() is unable to satisfy.  Many cases changed here in this
patch do not meet that criteria.

I'm tossing this entire patch series.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html