netdev - Re: [PATCH v2 net-next] net: introduce gro_frag_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20131103.181948.987234612453632341.davem@davemloft.net>
Date:	Sun, 03 Nov 2013 18:19:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sysoleg@...dex.ru
Cc:	hkchu@...gle.com, herbert@...dor.apana.org.au,
	eric.dumazet@...il.com, christoph.paasch@...ouvain.be,
	netdev@...r.kernel.org, mwdalton@...gle.com
Subject: Re: [PATCH v2 net-next] net: introduce gro_frag_list_enable sysctl

From: Oleg A. Arkhangelsky <sysoleg@...dex.ru>
Date: Sat, 02 Nov 2013 21:43:56 +0400

> 30.10.2013, 06:33, "David Miller" <davem@...emloft.net>:
> 
>> GRO should always win, even on a router, because it decreases the
>> number of fundamental operations (routing lookups) that the stack
>> needs to perform.
> 
> Yes, unless the case when you're using Linux as IP router which is
> forwarding 500K mixed IP (TCP and UDP) flows traffic @ 10-20 Gbit/s.
> Then GRO is unnecessarily overhead, cause there's no possibility to
> accumulate adequate GRO list in such scenario.

If it's not accumulating, then there really isn't much cost because
the bulk of the code paths are short circuited when the flow IDs do
not match.

We touch these packet headers to forward anyways, and that is the bulk
of the cost.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html