netdev - Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Nov 2013 09:59:17 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Alexey Orishko <alexey.orishko@...il.com>
Subject: Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_*

Joe Perches <joe@...ches.com> writes:

> You did most all the multi-line statement
> alignment perfectly but missed a couple.

Damn! OK, that will teach me to do "checkpatch --strict" before
submitting.

> Maybe in a follow-on patch.

Yes, I'll fix this when I get around to the next series for this driver.

Thanks.


Bjørn

>> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
> []
>> @@ -1031,17 +1035,13 @@ cdc_ncm_speed_change(struct usbnet *dev,
>>  	 * device speed. Do print it instead.
>>  	 */
>>  	if ((tx_speed > 1000000) && (rx_speed > 1000000)) {
>> -		printk(KERN_INFO KBUILD_MODNAME
>> -		       ": %s: %u mbit/s downlink "
>> -		       "%u mbit/s uplink\n",
>> -		       dev->net->name,
>> +		netif_info(dev, link, dev->net,
>> +		       "%u mbit/s downlink %u mbit/s uplink\n",
>>  		       (unsigned int)(rx_speed / 1000000U),
>>  		       (unsigned int)(tx_speed / 1000000U));
>>  	} else {
>> -		printk(KERN_INFO KBUILD_MODNAME
>> -		       ": %s: %u kbit/s downlink "
>> -		       "%u kbit/s uplink\n",
>> -		       dev->net->name,
>> +		netif_info(dev, link, dev->net,
>> +		       "%u kbit/s downlink %u kbit/s uplink\n",
>>  		       (unsigned int)(rx_speed / 1000U),
>>  		       (unsigned int)(tx_speed / 1000U));
>>  	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html