netdev - Re: [PATCH ] net_sched: actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131103.231232.1438716028901698864.davem@davemloft.net>
Date:	Sun, 03 Nov 2013 23:12:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jhs@...atatu.com, netdev@...r.kernel.org, ebiederm@...ssion.com,
	alexander.h.duyck@...el.com
Subject: Re: [PATCH ] net_sched: actions - Add default lookup

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 30 Oct 2013 07:00:05 -0700

> On Wed, 2013-10-30 at 07:25 -0400, Jamal Hadi Salim wrote:
>> Attached. Tested with simple action.
>> 
>> cheers,
>> jamal
> 
> Why not setting .lookup to tcf_hash_search
> in the few actions not already doing that ?
> 
> This would be more consistent.
> # git grep -n tcf_hash_search
> include/net/act_api.h:92:int tcf_hash_search(struct tc_action *a, u32 index);
> net/sched/act_api.c:198:int tcf_hash_search(struct tc_action *a, u32 index)
> net/sched/act_api.c:209:EXPORT_SYMBOL(tcf_hash_search);
> net/sched/act_csum.c:588:       .lookup         = tcf_hash_search,
> net/sched/act_gact.c:209:       .lookup         =       tcf_hash_search,
> net/sched/act_ipt.c:301:        .lookup         =       tcf_hash_search,
> net/sched/act_ipt.c:315:        .lookup         =       tcf_hash_search,
> net/sched/act_mirred.c:274:     .lookup         =       tcf_hash_search,
> net/sched/act_nat.c:311:        .lookup         =       tcf_hash_search,
> net/sched/act_pedit.c:246:      .lookup         =       tcf_hash_search,
> net/sched/act_police.c:410:     .lookup         =       tcf_hash_search,

Right, and BUG() if we try to register and action with a NULL .lookup
member.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html