netdev - Re: [PATCH net-next v2] bonding: add option to specify the number of queues per bond device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <527921DB.2090803@redhat.com>
Date:	Tue, 05 Nov 2013 17:50:35 +0100
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	netdev@...r.kernel.org
CC:	andy@...yhouse.net, fubar@...ibm.com, vfalico@...hat.com,
	davem@...emloft.net
Subject: Re: [PATCH net-next v2] bonding: add option to specify the number
 of queues per bond device

On 11/05/2013 05:47 PM, Nikolay Aleksandrov wrote:
> Before this patch the only way to specify the number of queues of a bond
> device was to use the tx_queues module parameter on module load. Since
> we can have different setups with different requirements, it's
> beneficial to be able to specify the number of queues per bond device
> creation. This patch adds this ability and uses tx_queues as a default
> and as a fallback in case of an invalid "queues" value.
> The queues are specified when creating a new bond device through sysfs
> by using " " as a delimiter between the name and the value, e.g.:
> echo "+bond1 8" > bonding_masters
> will create bond1 device with 8 queues.
> Add an example in the documentation, and also trim a few extra spaces
> and tabs while at it.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>
> ---

Aaaaargh, I'm not posting anymore patches today.
Self-nack again, I forgot about the queues initialization in the store_bonds and
that ends up in a warning when no value is specified, I'm so mad at myself.

Apologies again, this patch can be reviewed as I intend to post a v3 with the
proper initialization of queues to tx_queues in store_bonds as the only change.

Nik

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html