netdev - Re: [PATCH v2] can: add Renesas R-Car CAN driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a1ef40a4f59b71daf33f958d8cc5b2e@grandegger.com>
Date:	Wed, 06 Nov 2013 09:08:20 +0100
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	<netdev@...r.kernel.org>, <mkl@...gutronix.de>,
	<linux-can@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<vksavl@...il.com>
Subject: Re: [PATCH v2] can: add Renesas R-Car CAN driver

On Wed, 06 Nov 2013 01:59:26 +0300, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
> 
> On 11/03/2013 10:38 PM, Wolfgang Grandegger wrote:
> 
>>>>> Add support for the CAN controller found in Renesas R-Car SoCs.
> 
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
>>> [...]
> 
>>>>> Index: linux-can-next/drivers/net/can/rcar_can.c
>>>>> ===================================================================
>>>>> --- /dev/null
>>>>> +++ linux-can-next/drivers/net/can/rcar_can.c
>>>>> @@ -0,0 +1,920 @@
>>> [...]
> 
>>>>> +            rcar_can_writeb(priv, RCAR_CAN_ECSR, (u8)~ECSR_ADEF);
> 
>>>> Please avoid casts here and below.
> 
>>>     These casts help avoid compiler warnings.
> 
>> Well instead of using casts the declaration of ECSR_ADEF and otheres
>> should be fixed. I think the problem is that BIT is declared as shown
>> below:
> 
>>   #define BIT(nr)                 (1UL << (nr))
> 
>> Using BIT seems not appropriate here.
> 
>     Well, I thought it was designed to replace explicit (1 << (nr))
>     #define's.

Me too.

> Hopefully those are good for you then...

Yes, of course.

Wolfgang.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html