netdev - Re: [PATCH net-next 0/3] IPsec improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Nov 2013 10:02:13 +0100
From:	Mathias Krause <mathias.krause@...unet.com>
To:	David Miller <davem@...emloft.net>
CC:	steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	dmitry.tarnyagin@...kless.no, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/3] IPsec improvements

On 06.11.2013 05:48, David Miller wrote:
> From: Mathias Krause <mathias.krause@...unet.com>
> Date: Tue,  5 Nov 2013 14:54:08 +0100
> 
>> This series moves pskb_put() to the core code -- making the code
>> duplication in caif obsolete (patches 1 and 2).
>>
>> Additionally does this series optimize the IPsec receive path in patch 3
>> by allowing skb_cow_data() to leave the buffer fragmented. I noticed the
>> linearization to be a bottleneck when doing some VPN gateway benchmarks.
>> Linearization of the buffer isn't needed in the receive path as the
>> crypto API (and all other users of skb_cow_data) can handle sg.
>>
>> With patch 3 applied I was able to increase the throughput of an IPsec
>> gateway from 7.12 Gbit/s to 7.28 Gbit/s.
> 
> Please deal with the feedback given to you by Ben about referring to
> variables with the '@' prefix consistently in comments, then resend
> this entire patch series.

Will do. Thanks, Dave.

> 
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html