netdev - Re: [PATCH net-next 2/3] net_sched: fix some checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131106073741.154f8590@samsung-9>
Date:	Wed, 6 Nov 2013 07:37:41 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Yang Yingliang <yangyingliang@...wei.com>
Cc:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<eric.dumazet@...il.com>, <jhs@...atatu.com>
Subject: Re: [PATCH net-next 2/3] net_sched: fix some checkpatch errors

On Wed, 6 Nov 2013 16:05:08 +0800
Yang Yingliang <yangyingliang@...wei.com> wrote:

> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
> index fd70728..c8aadfa 100644
> --- a/net/sched/act_api.c
> +++ b/net/sched/act_api.c
> @@ -191,7 +191,7 @@ u32 tcf_hash_new_index(u32 *idx_gen, struct tcf_hashinfo *hinfo)
>  			val = 1;
>  	} while (tcf_hash_lookup(val, hinfo));
>  
> -	return (*idx_gen = val);
> +	return *idx_gen = val;

That is not an improvement. I would rather see the return on a assingment and return
on separate lines.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html