netdev - Re: [ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <527CC9E5.2070303@redhat.com>
Date:	Fri, 08 Nov 2013 12:24:21 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Thomas Graf <tgraf@...g.ch>
CC:	jesse@...ira.com, davem@...emloft.net, dev@...nvswitch.org,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [ovs-dev] [PATCH 2/2 net-next] openvswitch: Use skb_zerocopy()
 for upcall

On 11/08/2013 11:47 AM, Thomas Graf wrote:
> Use of skb_zerocopy() avoids the expensive call to memcpy() when
> copying the packet data into the Netlink skb. Completes checksum
> through skb_checksum_help() if needed.
>
> Netlink messaged must be properly padded and aligned to meet
> sanity checks of the user space counterpart.
>
> Cost of memcpy is significantly reduced from:
> +   7.48%       vhost-8471  [k] memcpy
> +   5.57%     ovs-vswitchd  [k] memcpy
> +   2.81%       vhost-8471  [k] csum_partial_copy_generic
>
> to:
> +   5.72%     ovs-vswitchd  [k] memcpy
> +   3.32%       vhost-5153  [k] memcpy
> +   0.68%       vhost-5153  [k] skb_zerocopy
>
> (megaflows disabled)
>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> Cc: Jesse Gross <jesse@...ira.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>

Reviewed-by: Daniel Borkmann <dborkman@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html