netdev - Re: [PATCH net-next v3 1/3] ipv6: enable IPV6_FLOWLABEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131108.134324.1679400843866741415.davem@davemloft.net>
Date:	Fri, 08 Nov 2013 13:43:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	florent.fourcot@...t-bretagne.fr, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/3] ipv6: enable IPV6_FLOWLABEL_MGR for
 getsockopt

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Fri, 8 Nov 2013 13:27:49 +0100

> On Thu, Nov 07, 2013 at 05:53:12PM +0100, Florent Fourcot wrote:
>> It is already possible to set/put/renew a label
>> with IPV6_FLOWLABEL_MGR and setsockopt. This patch
>> add the possibility to get information about this
>> label (current value, time before expiration, etc).
>> 
>> It helps application to take decision for a renew
>> or a release of the label.
>> 
>> v2:
>>  * Add spin_lock to prevent race condition
>>  * return -ENOENT if no result found
>>  * check if flr_action is GET
>> 
>> v3:
>>  * move the spin_lock to protect only the
>>    relevant code
>> 
>> Signed-off-by: Florent Fourcot <florent.fourcot@...t-bretagne.fr>
> 
> There still are some locking anomalies in ip6_flowlabel. But none
> has something to do with your patches. E.g. mem_check runs without
> rcu_read_lock.
> 
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html