netdev - Re: [PATCH] Fix "ip rule delete table 256"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131108.145401.703012257935119294.davem@davemloft.net>
Date:	Fri, 08 Nov 2013 14:54:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andreas@...al.se
Cc:	netdev@...r.kernel.org, shemminger@...workplumber.org
Subject: Re: [PATCH] Fix "ip rule delete table 256"

From: Andreas Henriksson <andreas@...al.se>
Date: Thu, 7 Nov 2013 18:26:38 +0100

> When trying to delete a table >= 256 using iproute2 the local table
> will be deleted.
> The table id is specified as a netlink attribute when it needs more then
> 8 bits and iproute2 then sets the table field to RT_TABLE_UNSPEC (0).
> Preconditions to matching the table id in the rule delete code
> doesn't seem to take the "table id in netlink attribute" into condition
> so the frh_get_table helper function never gets to do its job when
> matching against current rule.
> Use the helper function twice instead of peaking at the table value directly.
> 
> Originally reported at: http://bugs.debian.org/724783
> 
> Reported-by: Nicolas HICHER <nhicher@...ncall.com>
> Signed-off-by: Andreas Henriksson <andreas@...al.se>

Good catch, applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html