netdev - Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87txfm8vz5.fsf@nemi.mork.no>
Date:	Fri, 08 Nov 2013 21:44:14 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Dan Williams <dcbw@...hat.com>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	John Henderson <jhen@...k21.com>
Subject: Re: [RFC] Revert "sierra_net: keep status interrupt URB active"

Dan Williams <dcbw@...hat.com> writes:
> On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote:
>> On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote:
>> > This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf.
>> > 
>> > It's not easy to create a driver for all the various firmware
>> > bugs out there.
>> > 
>> > This change caused regressions for a number of devices, which
>> > started to fail link detection and therefore became completely
>> > non-functional. The exact reason is yet unknown, it looks like
>> > the affected firmwares might actually need all or some of the
>> > additional SYNC messages the patch got rid of.
>> > 
>> > Reverting is not optimal, as it will re-introduce the original
>> > problem, but it is currently the only alternative known to fix
>> > this issue.
>> 
>> Instead, how does the following patch work for you?
>
> Bjorn, did you have a chance to try this patch out on your devices?

The only DirectIP device I have is the MC7710, which never had any of
the firmware issues you are trying to fix. I only tried to forward Johns
issue.

When this patch worked for John, then I am pretty confident that you
have solved the problem here.



Thanks,
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html