netdev - Re: [PATCH net] tg3: avoid double-freeing of rx data memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Nov 2013 19:10:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ivecera@...hat.com
Cc:	netdev@...r.kernel.org, nsujir@...adcom.com, mchan@...adcom.com
Subject: Re: [PATCH net] tg3: avoid double-freeing of rx data memory

From: Ivan Vecera <ivecera@...hat.com>
Date: Wed,  6 Nov 2013 14:02:36 +0100

> If build_skb fails the memory associated with the ring buffer is freed but
> the ri->data member is not zeroed in this case. This causes a double-free
> of this memory in tg3_free_rings->... path. The patch moves this block after
> setting ri->data to NULL.
> It would be nice to fix this bug also in stable >= v3.4 trees.
> 
> Cc: Nithin Nayak Sujir <nsujir@...adcom.com>
> Cc: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html