lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Nov 2013 11:07:05 +0800 From: wangweidong <wangweidong1@...wei.com> To: Joe Perches <joe@...ches.com> CC: <vyasevich@...il.com>, <nhorman@...driver.com>, <dingtianhong@...wei.com>, <davem@...emloft.net>, <linux-sctp@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 2/5] sctp: remove the else path On 2013/11/8 11:00, Joe Perches wrote: > On Fri, 2013-11-08 at 10:55 +0800, Wang Weidong wrote: >> Make the code more simplification. >> >> Signed-off-by: Wang Weidong <wangweidong1@...wei.com> >> --- >> net/sctp/associola.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/net/sctp/associola.c b/net/sctp/associola.c >> index 667f984..2d53d4c 100644 >> --- a/net/sctp/associola.c >> +++ b/net/sctp/associola.c >> @@ -954,15 +954,13 @@ int sctp_cmp_addr_exact(const union sctp_addr *ss1, >> */ >> struct sctp_chunk *sctp_get_ecne_prepend(struct sctp_association *asoc) >> { >> - struct sctp_chunk *chunk; >> + struct sctp_chunk *chunk = NULL; >> >> /* Send ECNE if needed. >> * Not being able to allocate a chunk here is not deadly. >> */ >> if (asoc->need_ecne) >> chunk = sctp_make_ecne(asoc, asoc->last_ecne_tsn); >> - else >> - chunk = NULL; >> >> return chunk; >> } > > If you really want to make the code simple how about: > > struct sctp_chunk *sctp_get_ecne_prepend(struct sctp_association *asoc) > { > if (!asoc->need_ecne) > return NULL; > > return sctp_make_ecne(asoc, asoc->last_ecne_tsn); > } > > Yeah, you are right. I will fix it in v2. Thanks. > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists