netdev - Re: [PATCH net-next] nfnetlink: do not ack malformed messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <slrnl7tpcq.5er.xiyou.wangcong@linux-6brj.site>
Date:	Sun, 10 Nov 2013 01:46:56 +0000 (UTC)
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] nfnetlink: do not ack malformed messages

On Thu, 07 Nov 2013 at 23:03 GMT, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
>> --- a/net/netfilter/nfnetlink.c
>> +++ b/net/netfilter/nfnetlink.c
>> @@ -363,13 +363,15 @@ static void nfnetlink_rcv(struct sk_buff *skb)
>>   	struct net *net = sock_net(skb->sk);
>>   	int msglen;
>>
>> -	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
>> -		return netlink_ack(skb, nlh, -EPERM);
>> -
>
>     Hm, how it even compiled before your patch?
>

You can return void inside a void function.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html