lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Nov 2013 21:03:55 -0500 (EST) From: David Miller <davem@...emloft.net> To: ogerlitz@...lanox.com Cc: netdev@...r.kernel.org, amirv@...lanox.com, eyalpe@...lanox.com Subject: Re: [PATCH net-next FIX] RDMA/cma: Fix build breakage when infiniband is built-in From: Or Gerlitz <ogerlitz@...lanox.com> Date: Sun, 10 Nov 2013 15:28:00 +0200 > From: Eyal Perry <eyalpe@...lanox.com> > > Commit eb072c4 ("RDMA/cma: Set IBoE SL (user-priority) by egress map when using > vlans"), broke the build when CONFIG_VLAN_8021Q=m and CONFIG_INFINIBAND=y, > because the rdma_cm module attempted to call vlan_dev_get_egress_qos_mask() > which in that case is a modular code being called from built-in kernel code. > > Fix this by adding a Kconfig dependency to prevent the rdma_cm code from being > built in when 8021Q is built modular, in a similar manner we do with IPv6. > > Signed-off-by: Eyal Perry <eyalpe@...lanox.com> > Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com> > --- > > Dave, this fixes an issue with the mentioned commit which is in net-next Please just move vlan_dev_get_egress_qos_mask into include/linux/if_vlan.h and make it an inline function. These Kconfig restrictions are just beyond silly and unnecessary. I bet the IPV6 one already there can be killed by moving some things into net/ipv6/*_core.c files as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists