netdev - Re: [PATCH] net/7990: Make lance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131112.181629.742226266240112179.davem@davemloft.net>
Date:	Tue, 12 Nov 2013 18:16:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
	linux-m68k@...r.kernel.org
Subject: Re: [PATCH] net/7990: Make lance_private.name const

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Tue, 12 Nov 2013 23:44:06 +0100

> On Wed, Nov 13, 2013 at 12:40 AM, Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com> wrote:
>> On 11/13/2013 12:12 AM, David Miller wrote:
>>
>>>>> @@ -100,7 +100,7 @@ struct lance_init_block {
>>>>>     */
>>>>>    struct lance_private
>>>>>    {
>>>>> -        char *name;
>>>>> +        const char *name;
>>
>>
>>>>     Indent with tab, not spaces, please.
>>
>>
>>> This whole file is %99 space indentation, you really can't blame
>>> Geert for this.
>>
>>
>>    It's never late to fix some.
> 
> That would be a separate patch. Care to create and send it?
> 
>> And remember about checkpatch.pl which was hardly content with the patch.
> 
> Only because checkpatch looks at the _new_ lines, and doesn't compare the
> styles of the old and new lines.

You really should fix the line you are changing to use tabs, please respin
with this in mind, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html