netdev - Re: [PATCH 2/2] random32: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131112234710.GI14929@order.stressinduktion.org>
Date:	Wed, 13 Nov 2013 00:47:10 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Daniel Borkmann <dborkman@...hat.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] random32: use msecs_to_jiffies for reseed timer

On Tue, Nov 12, 2013 at 03:35:12PM -0800, Stephen Hemminger wrote:
> On Tue, 12 Nov 2013 23:45:42 +0100
> Daniel Borkmann <dborkman@...hat.com> wrote:
> 
> > Use msecs_to_jiffies, for these calculations as different HZ
> > considerations are taken into account for conversion of the timer
> > shot, and also it makes the code more readable.
> > 
> > Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> > Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > ---
> >  lib/random32.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/random32.c b/lib/random32.c
> > index 4f9d5df..1e5b2df 100644
> > --- a/lib/random32.c
> > +++ b/lib/random32.c
> > @@ -214,18 +214,22 @@ static DEFINE_TIMER(seed_timer, __prandom_timer, 0, 0);
> >  static void __prandom_timer(unsigned long dontcare)
> >  {
> >  	u32 entropy;
> > +	unsigned long expires;
> >  
> >  	get_random_bytes(&entropy, sizeof(entropy));
> >  	prandom_seed(entropy);
> > +
> >  	/* reseed every ~60 seconds, in [40 .. 80) interval with slack */
> > -	seed_timer.expires = jiffies + (40 * HZ + (prandom_u32() % (40 * HZ)));
> > +	expires = 40 + (prandom_u32() % 40);
> > +	seed_timer.expires = jiffies + msecs_to_jiffies(expires * MSEC_PER_SEC);
> > +
> >  	add_timer(&seed_timer);
> >  }
> >  
> >  static void __init __prandom_start_seed_timer(void)
> >  {
> >  	set_timer_slack(&seed_timer, HZ);
> > -	seed_timer.expires = jiffies + 40 * HZ;
> > +	seed_timer.expires = jiffies + msecs_to_jiffies(40 * MSEC_PER_SEC);
> >  	add_timer(&seed_timer);
> >  }
> >  
> 
> Some questions:
>  1. What is the point of using msecs_to_jiffies? the older code already handled
>     differing HZ?

The change is not that important. It seemed a bit more readable. We could
certainly drop that.

>  2. Why the magic 40-80 sec range? What about platforms with very low entropy
>     you will end up draining it faster.

Daniel and me had a discussion about that. I originally had it even lower and
Daniel warned about that. The current window seemd fine to me as we don't want
to have a too big window where one could probe ports if an attacker could find
a bias in the PRNG. Do you have a suggestion?

>  3. I prefer using mod_timer rather than setting expires and call add_timer

I wanted the BUG_ON in add_timer in the code path so we can make sure no
two timers are running concurrently. Would be no problem to change that.

>  4. You should also use round_jiffies to save power by making the wakeup on a second
>     boundary.

We already apply slack when initializing the timer:

static void prandom_start_seed_timer(void)
{
        set_timer_slack(&seed_timer, HZ);
        seed_timer.expires = jiffies + 40 * HZ;
        add_timer(&seed_timer);
}

It thus does get rounded by apply_slack in mod_timer.

Greetings,

  Hannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html