netdev - Re: [PATCH] mac80211: minstrels: spare numerous useless calls to get_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1384367646.14578.24.camel@jlt4.sipsolutions.net>
Date:	Wed, 13 Nov 2013 19:34:06 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Karl Beldan <karl.beldan@...il.com>
Cc:	Felix Fietkau <nbd@...nwrt.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	netdev@...r.kernel.org, Karl Beldan <karl.beldan@...ierawaves.com>
Subject: Re: [PATCH] mac80211: minstrels: spare numerous useless calls to
 get_random_bytes

On Wed, 2013-11-13 at 10:54 +0100, Karl Beldan wrote:
> From: Karl Beldan <karl.beldan@...ierawaves.com>
> 
> ATM, only the first array value returned by get_random_bytes is used.
> This change moves the call to get_random_bytes from the nested loop it
> is in to its parent.
> While at it, replace get_random_bytes with prandom_bytes since PRNs are
> way enough for the selection process.
> After this, minstrel_ht reclaims 80 PR-bytes instead of 640 R-bytes.

Applied.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html